[Dune] redundant includes in headers

Oleh Krehel krehel at am.uni-erlangen.de
Fri Aug 19 15:43:47 CEST 2011


Dear DUNE developers,

I've noticed this group of includes in fvector.hh:

#include<cmath>
#include<cstddef>
#include<cstdlib>
#include<complex>
#include<cstring>

Are they really necessary? Because when I've commented them away,
everything still works.
But in fiedmatrix.hh it's definitely redundant:

#include <cmath>
#include <cstddef>
#include <iostream>

#include <dune/common/misc.hh>
#include <dune/common/exceptions.hh>
#include <dune/common/fvector.hh> // includes again <cmath> and <cstddef>

I realize that it's not a priority and redundancies don't break anything,
but perhaps removing them could save a few milliseconds of build time:)

I've read that the static analyzer features of eclipse or clang can
automatically
find the redundant/unused includes.

best regards,
Oleh Krehel




More information about the Dune mailing list