[Dune] headercheck

[Carsten Gräser]

Hi Jö,

Am 21.01.2011 18:10, schrieb Jö Fahlke:
> Am Fri, 21. Jan 2011, 17:32:26 +0100 schrieb Carsten Gräser:
>> 1) Whats's the difference between the make targets
>>    headercheck, headercheck-am, and headercheck-recursive?
> 
> My guess is the following:
> 
>  * "headercheck-am" runs the headercheck in the current directory only,
> 
>  * "headercheck-recursive" calls "make -C $subdir headercheck" for all subdirs
>    and "make -C . headercheck-am" for the current directory
> 
>  * "headercheck" is the user-friendly version: it checks whether a particular
>    header is to checked (if HEADER is set) and avoids recursion in this case.
> 
>> 2) Our module has a test for an external library that defines
>>    FOO_CPPFLAGS for usage in the applications Makefile.am.
>>    Unfortunately, 'make headercheck' is not aware of this
>>    include. What's the desired way to provide the flags to
>>    the headercheck?
> 
> I don't think there is a way to pass additional flags beyond those from
> ALL_PKG_*.  Maybe you can provide some values that will work in most cases by
> making use of an "#ifdef HEADERCHECK"-conditional.  Or you header simply does
> not work with headercheck, then you can add it to the "headercheck_IGNORE"
> makefile-variable.  Unfortunately, when a header appears in
> "headercheck_IGNORE", headercheck will ignore it not only when it just checks
> all headers in a directory, but also when you request checking that header
> explicitly.
> 
>>    I suspect one has to call DUNE_ADD_ALL_PKG in the test - at least
>>    this should work. However, it's not documented what is supposed
>>    to be in the ALL_PKG_* variables.
> 
> AFAICR ALL_PKG_* is supposed to contain all flags of all detected libraries,
> whether they are optional or not (except for cases like Alberta where they
> conflict).
OK, then the flags of this optional library should also be put in ALL_PKG_*
and are thus used by headercheck. So there is no need to for an additional
mechanism.

Thanks,

Carsten