[Dune] [#604] move reference element related stuff to separate module

Dune flyspray at dune-project.org
Mon Jun 13 22:05:03 CEST 2011


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#604 - move reference element related stuff to separate module
User who did this - Jö Fahlke (joe)

----------
For the record: I'm think we should postpone the namespace issue as well.

As to the GeometryType issue: I just thought of another way of handling this.
We keep the implementation in Dune-Common for now but make sure a warning is
emitted every time <dune/common/geometrytype.hh> is included directly.
Something along these lines:

== dune/common/geometrytype.hh =======================================
#ifndef DISABLE_GEOMETRYTYPE_DEPRECATION_WARNING
#warning #include <dune/common/geometrytype.hh> is deprecated.  Use
#warning #include <dune/geometry/type.hh> instead.  You may need the new
#warning Dune-Geometry core module.
#endif // DISABLE_GEOMETRYTYPE_DEPRECATION_WARNING

#ifndef DUNE_COMMON_GEOMETRYTYPE_HH
#define DUNE_COMMON_GEOMETRYTYPE_HH
[...]
#endif // DUNE_COMMON_GEOMETRYTYPE_HH
======================================================================

== dune/geometry/type.hh =============================================
#ifndef DUNE_GEOMETRY_TYPE_HH
#define DUNE_GEOMETRY_TYPE_HH

#define DISABLE_GEOMETRYTYPE_DEPRECATION_WARNING
#include <dune/common/geometrytype.hh>
#undef DISABLE_GEOMETRYTYPE_DEPRECATION_WARNING

#endif // DUNE_GEOMETRY_TYPE_HH
======================================================================

After the deprecation period is finished, we can simply move the contents of
<dune/common/geometrytype.hh> to <dune/geometry/type.hh>.  That should really
allow for a clean transition.

----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=604#comment2624

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list