[Dune] [#957] Remove grid dimension from BasicGeometry

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#957 - Remove grid dimension from BasicGeometry
User who did this - Martin Nolte (nolte)

----------
You are right Oli, these parameters might exist for purely historic reasons. The BasicGeometry is a model implementation for Dune::Geometry and this class even depends on a grid as a template argument, so we never bothered with the question. Notice that the grid dimension and world dimension is also exported by Dune::Geometry.

I agree with you that a geometry should not depend explicitly on any grid (unless an implementation requires it). So I would rather ask the question, whether the template argument GridImp should not be removed from Dune::Geometry.

To really solve this problem (and remove Jö's MockGeometry), I would suggest to modify the template argument list of Dune::Geometry as follows:

template< class ct, int mydim, int cdim, class GeometryImp >
class Geometry;

If I'm not mistaken, all the necessary information can be extracted from these template arguments (ct is, of course, the grid's ctype).

Without such a change, I consider the removal of these quantities wrong, because in my world an implementation should also export all constants exported by the facade (in this case Dune::Geometry).
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=957#comment2706

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.