[Dune] [#1067] MatrixIndexSet sould use size_type or similar

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#1067 - MatrixIndexSet sould use size_type or similar
User who did this - Christoph Grüninger (gruenich)

----------
I am not sure if everybody is aware of the advantages of std::size_t over unsigned int, cf. [0, 1]. I think we should encourage that new code will be written with more std::size_t and less (unsigned) int in loops and indices.

Nevertheless I gained the impression that Dune tries to avoid code changes when they are only for aesthetics. For example a commit with changes in the indention or moving brackets around are disapproved. So "no one ever came around doing it" is more of a "once someone did it that way and nobody changes it without a good reason". A good reason would be for me e.g. portability, a real speed gain or compiler warnings.

This is my point of view and no Dune policy. But it is enough to prevent me from applying your patch unless a core developer encourages me otherwise. And I'd use std::size and change to auto in the long run for consistency - but again a matter of aesthetics...

[0] http://eetimes.com/discussion/programming-pointers/4026076/Why-size-t-matters
[1] http://www.viva64.com/en/a/0050/
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=1067#comment3354

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.