[Dune] [Dune-Commit] dune-grid r8001 - in trunk/dune/grid: genericgeometry/test utility/test

[Christian Engwer]

On Mon, Apr 23, 2012 at 10:08:06AM +0200, Christoph Grüninger wrote:
> Hi Christian,
> the renaming was necessary because the GeometryType typedef was very
> misleading and it took me some minutes to figure out why
> GeometryType::id() was not found by the compiler.
> 
> Should I have split the commit into two commits?

Yes, it would have been more readable.

Christian

> Greets
> Christoph
> 
> 
> Am 23.04.2012 10:01, schrieb Christian Engwer:
> >Hi Christoph,
> >
> >>Log:
> >>Get rid of another two deprecation warnings.
> >
> >...
> >
> >>Modified: trunk/dune/grid/genericgeometry/test/testgeo.cc
> >>===================================================================
> >>--- trunk/dune/grid/genericgeometry/test/testgeo.cc	2012-04-21 13:07:55 UTC (rev 8000)
> >>+++ trunk/dune/grid/genericgeometry/test/testgeo.cc	2012-04-23 05:15:51 UTC (rev 8001)
> >>@@ -122,8 +122,8 @@
> >
> >...
> >
> >>-    const unsigned int topologyId = GenericGeometry::topologyId( geoDune.type() );
> >>+    const GeometryType gt = geoDune.type();
> >
> >If I spotted this correctly, you basically changed one single line to
> >fix the warning, but renaming some types and variables lead to a
> >8-times larger patch. I understand that it sometime helps to rename
> >types to understand the code, but in this case I think the code was
> >quite readable and the renaming hides the actual fix quite
> >efficiently.
> >
> >Christian
> 
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
>