[Dune] [#587] GenericReferenceElements should use unsigned for indices, sizes etc.

[Christoph Grüninger]

Hi,
I think Matthias is right. Is there a reason to store dim_ in GeometryType as
an unsigned char? Otherwise I plead for changing it to unsigned int.

Bye
Christoph

Dune <flyspray at dune-project.org> schrieb:
>THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
>
>The following task has a new comment added:
>
>FS#587 - GenericReferenceElements should use unsigned for indices, sizes etc.
>User who did this - Matthias Wohlmuth (matthias)
>
>----------
>May I ask about the situation in dune/common/geometrytype.hh: It is stated that both 
>constructors with types unsigned int and int for the dimension are needed to distinguish 
>between topologyId and dim. I'm not sure if I like that, but at least it seems to be 
>intended. 
>However, is there a reason that the member _dim is stored as unsigned char. This results 
>in -Wtype-limits warnings when _dim is set in the int/unsigned int constructors... 
>Probably, that's not a big deal, but I'm just curious.... ----------