[Dune] [#587] GenericReferenceElements should use unsigned for indices, sizes etc.

Dune flyspray at dune-project.org
Tue Apr 24 22:49:16 CEST 2012


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#587 - GenericReferenceElements should use unsigned for indices, sizes etc.
User who did this - Oliver Sander (sander)

----------
@Matthias: _dim is an unsigned char for historic reasons.  When I originally wrote the class it had two members basicType and dim.  Both are basically positive integers, and will never takes very large values.  Therefore I make _dim a char (and modified basicType) such that the entire class would fit into a 32bit word.  I never measured whether that actually did speed up anything.  Later people added more members, and the original idea got lost.  Feel free to change _dim to a bigger unsigned type.

@Christoph: Go ahead.  I think it is a good idea and chances of breaking anything are extremely low.
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=587#comment3404

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list