[Dune] Some tests in dune-localfunctions are just built and never run

[Oliver Sander]

Am 30.08.2012 10:24, schrieb Markus Blatt:
> Hi Andreas,
>
> thanks for the explanation. No I do not want to remove them, but would
> prefer to move into a subdirectory named test. Would that be OK?
>
Hi,
I have also found those tests by accident a while ago.  I agree with Markus
that they should be moved somehwere else.  And giving them better names than
simply 'test.cc' would also seem like a good idea to me.

 From Andreas description it seems that some of them are not really unit 
tests
at all.  A program that prints a basis function in a human-readable form is
certainly useful, but it is not a test.  Maybe these programs can go into
a 'utility' or 'src' directory.

Best,
Oliver




> Cheers,
>
> Markus
> On Mon, Aug 27, 2012 at 08:27:49PM +0000, Dedner, Andreas wrote:
>> Hi.
>>
>> Das waren eher Tests, die wir geschrieben haben als wir die Basisfunktionen implemeniert haben.
>> Bei event. Weiterentwicklung waer es praktisch die zu haben, sie schreiben etwa die Basisfunktioen
>> raus zum anschauen mit matlab oder so. Wenn sie stoeren koennen sie aber auch weg - ich kann sie
>> mir ja aus dem repo wiederholen.
>>
>> Andreas
>>
>> ________________________________________
>> From: dune-bounces+a.s.dedner=warwick.ac.uk at dune-project.org [dune-bounces+a.s.dedner=warwick.ac.uk at dune-project.org] on behalf of Markus Blatt [markus at dr-blatt.de]
>> Sent: 27 August 2012 21:10
>> To: dune at dune-project.org
>> Subject: [Dune] Some tests in dune-localfunctions are just built and never      run
>>
>> Hi,
>>
>> in dune-localfunctions there are some tests, namly test and test_all
>> in the directories dune/localfunctions/orthonormal/,
>> ./dune/localfunctions/lagrange/, and
>> ./dune/localfunctions/raviartthomas/, that are just built during make
>> check, but never run. Moreover they are as in other modules located in
>> a subdirectory named test.
>>
>> Is there a special reason for this?
>>
>> Cheers,
>>
>> Markus
>