[Dune] Returning Geometries As Objects

[Martin Nolte]

Hi Christoph,

thanks a lot for this comforting information. With respect to 
pyramidtriangulation.cc, I'll have a look into it before merging the branch. I 
have to admit that, until now, I did not succeed in running 'make check' on 
dune-grid.

Best,

Martin


On 02/03/2012 05:24 PM, "Christoph Grüninger" wrote:
>   Hi Martin,
> as you asked, I compared your branch with the current
> trunk for dune-PDELab (trunk) and DuMuX (trunk). Both
> compiled and make check had the same number of passing
> tests.
> I did no benchmarking nor did I check for warnings. I
> did not use external grids for my comparison.
>
> My make check in dune-grid did not compile two tests
> because pyramidtriangulation seems to contain an error:
>
> ../../../../../dune/grid/common/refinement/pyramidtriangulation.cc: In
> member function
> ‘Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<dimension,
> CoordType, 0>::Geometry
> Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<dimension,
> CoordType, 0>::geometry() const [with int dimension = 3, CoordType =
> double,
> Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<dimension,
> CoordType, 0>::Geometry = Dune::Geometry<3, 3,
> Dune::RefinementImp::PyramidTriangulation::RefinementImp<3, double>,
> Dune::RefinementImp::PyramidTriangulation::Geometry>]’:
> ../../../../../dune/grid/common/refinement/pyramidtriangulation.cc:308:54:
> instantiated from
> ‘Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<dimension,
> CoordType, 0>::CoordVector
> Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<dimension,
> CoordType, 0>::coords() const [with int dimension = 3, CoordType = double,
> Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<dimension,
> CoordType, 0>::CoordVector = Dune::FieldVector<double, 3>]’
> ../../../../../dune/grid/common/virtualrefinement.cc:542:27: instantiated
> from ‘Dune::VirtualRefinementImp<topologyId, CoordType, coerceToId,
> dimension>::SubEntityIteratorBack<codimension>::CoordVector
> Dune::VirtualRefinementImp<topologyId, CoordType, coerceToId,
> dimension>::SubEntityIteratorBack<codimension>::coords() const [with int
> codimension = 0, unsigned int topologyId = 2u, CoordType = double, unsigned
> int coerceToId = 0u, int dimension = 3,
> Dune::VirtualRefinementImp<topologyId, CoordType, coerceToId,
> dimension>::SubEntityIteratorBack<codimension>::CoordVector =
> Dune::FieldVector<double, 3>]’
> subsamplingvtktest.cc:144:1: instantiated from here
> ../../../../../dune/grid/common/refinement/pyramidtriangulation.cc:321:24:
> error: could not convert ‘((const
> Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<3,
> double,
> 0>*)this)->Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<3,
> double, 0>::geometry_’ from
> ‘Dune::RefinementImp::PyramidTriangulation::Geometry<3, 3,
> Dune::RefinementImp::PyramidTriangulation::RefinementImp<3, double>  >’ to
> ‘Dune::RefinementImp::PyramidTriangulation::RefinementIteratorSpecial<3,
> double, 0>::Geometry {aka Dune::Geometry<3, 3,
> Dune::RefinementImp::PyramidTriangulation::RefinementImp<3, double>,
> Dune::RefinementImp::PyramidTriangulation::Geometry>}’
> ../../../../../dune/grid/common/refinement/pyramidtriangulation.cc:322:13:
> warning: control reaches end of non-void function [-Wreturn-type]
> make[6]: *** [subsamplingvtktest-subsamplingvtktest.o] Fehler 1
> Bye
> Christoph
>
> P. S.: Sorry if you got the email multiple times but I
> had technical issues with my email at the university.
>
> --
> Actually, most flamewars are caused
> by Vim being much worse than Emacs.
> [http://science.slashdot.org/comments.pl?sid=177208&cid=14705579]
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune

-- 
Dr. Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5630
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany