[Dune] [Dune-Commit] dune-common r6545 - trunk/dune/common

[Oliver Sander]

Hi Robert,
I don't really get it, either.  It seems like all direct access of 
MyFiniteStack
to the formerly-private data members of its base class ReservedVector 
could be
easily replaced by using normal interface methods of latter class.  Why the
direct access?
best,
Oliver

Am 09.01.2012 12:18, schrieb Christian Engwer:
> Hi Robert,
>
> On Mon, Jan 09, 2012 at 12:04:09PM +0100, robertk at dune-project.org wrote:
>> Author: robertk
>> Date: 2012-01-09 12:04:09 +0100 (Mon, 09 Jan 2012)
>> New Revision: 6545
>>
>> Modified:
>>     trunk/dune/common/reservedvector.hh
>> Log:
>> only protect data for further use.
>
> strictly speaking this is an interface change.
>
> All protected members are practically public and thus become part of
> the interface (can not be changed without adapting all derived
> classes).
>
> Could you elaborate, what you intent with this patch?
>
> Cheers
> Christian
>
>
>>
>>
>>
>> Modified: trunk/dune/common/reservedvector.hh
>> ===================================================================
>> --- trunk/dune/common/reservedvector.hh	2012-01-08 18:44:05 UTC (rev 6544)
>> +++ trunk/dune/common/reservedvector.hh	2012-01-09 11:04:09 UTC (rev 6545)
>> @@ -187,7 +187,7 @@
>>               return s;
>>           }
>>
>> -    private:
>> +    protected:
>>           T data[n];
>>           size_type sz;
>>       };
>>
>>
>> _______________________________________________
>> Dune-Commit mailing list
>> Dune-Commit at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-commit
>>
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune