[Dune] [#965] dune-grid fails headercheck

Dune flyspray at dune-project.org
Fri Jan 27 18:38:22 CET 2012


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#965 - dune-grid fails headercheck
User who did this - Jö Fahlke (joe)

----------
>From the point of view of the autotools it is a header, and it should have one of the usual c++ header extensions so there is no chance they get confused.

Now we can discuss whether it is conceptually a header, but I consider that discussion a waste of time.

If you really don't like *.hh how about something like *_imp.hh, e.g volume_main_imp.hh?

Regardless of that, I'd simply put that file into HEADERCHECK_IGNORE.  Another correct solution would be to wrap the main function into #ifndef HEADERCHECK/#endif, that way at least the #include lines get checked.

With other programs using the same pattern, you could also detect HEADERCHECK mode, provide a dummy typedef Grid to e.g. SGrid etc., and use a different name for main.  But this particular program really only works with ALUGrids (since it relies on an alugrid-specific constructor), so testing of (a renamed) main() can only can only work when ALUGrid is present.  It's probably not worth the hassle.

@Christoph: BTW, I consider this particular subtask owned by you, if you loose interest, please say so, then I'll deal with it.
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=965#comment3146

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list