[Dune] [Dune-Commit] dune-grid r8017 - trunk/dune/grid/genericgeometry/test

Jö Fahlke jorrit at jorrit.de
Wed May 2 18:49:07 CEST 2012


Am Wed,  2. May 2012, 14:29:17 +0200 schrieb Jö Fahlke:
> isnan() isn't part of the C++2003 standard, as far as I could determine.  It
> is part of C99, but it is a macro there.  So we definitely should remove the
> namespace from it.

It's even worse than that: isnan() is a function in C++11.  I'm not sure how
one is supposed to use it in a way that satisfies both C++11 compilers and
older ones.

The attached patch fixes this by avoiding the use of NaNs and other special
values for volume altogether.

@Oliver: Can I check this in or should I wait until you have branched?

Bye,
Jö.

-- 
Jorrit (Jö) Fahlke, Interdisciplinary Center for Scientific Computing,
Heidelberg University, Im Neuenheimer Feld 368, D-69120 Heidelberg
Tel: +49 6221 54 8890 Fax: +49 6221 54 8884

In the beginning the Universe was created.  This has made a lot of
people very angry and been widely regarded as a bad move.
-- Douglas Adams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-testbasicgeometry-Avoid-NaNs-altogether-by-splitting.patch
Type: text/x-diff
Size: 14779 bytes
Desc: not available
URL: <https://lists.dune-project.org/pipermail/dune/attachments/20120502/b4ef92f0/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune/attachments/20120502/b4ef92f0/attachment-0001.pgp>


More information about the Dune mailing list