[Dune] [Dune-devel] Reference and pointer type when dereferencing EntityPointer

Oliver Sander sander at igpm.rwth-aachen.de
Mon Oct 20 10:50:12 CEST 2014


Am 20.10.2014 um 10:24 schrieb Robert Kloefkorn:
> Hello Steffen,
> 
>> OK, in that case I propose making those return types const. If nobody
>> cries foul until tomorrow, I’ll push the change.
> 
> although your contributions to dune-grid are very welcome you should not
> do interfaces changes in the way you did last week.
> 
> Even though the change was obvious it still seems to be open heart
> surgery, especially a non-const to const change calls for trouble.
> Like for any other interface change there must be a vote (doodle) and at
> least a proper notice time (and not something like I'll do it tomorrow).
> 
> So for future changes to the core modules please be more responsible.
> 

Hi Robert,
technically you are right and this is an interface change.  Nevertheless personally
I looked at it more like a bug, since pretty much everything the grid interface
returns is const.  Therefore I didn't expect a vote on this and in my eyes Steffen's
behavior is fine.
Best,
Oliver


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune/attachments/20141020/6ccc2cb7/attachment.sig>


More information about the Dune mailing list