[Dune] grid.geometry is a bit restrictive

Aleksejs Fomins aleksejs.fomins at lspr.ch
Fri Feb 27 15:41:52 CET 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dear Christian,

So do I understand correctly that you suggest to use getRealImplementation on user side to get the extra methods of the underlying grid.geometry() implementation? I think this would work too

Anyway, I think it would be a good idea to open a feature request. I will explain what methods I provide and why I believe they are useful to the user, and then you people can decide on whether you want to add some of them to the main interface or keep them to the auxiliary interface.

Could you please briefly explain how to open a feature request?

Thanks,
Aleksejs


On 27/02/15 15:34, Christian Engwer wrote:
> Dear Aleksejs,
> 
> On Fri, Feb 27, 2015 at 12:06:16PM +0100, Aleksejs Fomins wrote:
>> Dear Dune,
>>
>> I just realised that CurvilinearGeometry has quite a few new user methods compared to linear geometries, for example, access to interpolation vertices, interpolation polynomials and functions thereof. The wrapper interface of grid.geometry class does not allow for adding these additional methods, so they will need to be accessed some other way.
>>
>> I have decided to provide a grid method grid.basegeometry(entity),
>> which would directly return the Dune::CurvilinearGeometry class, and
>> not its grid wrapper. I realise that this goes against the paradigm of
>> "protecting the users from themselves", but I do not see a good
>> alternative at the moment.
> 
> There is the method grid.getRealImplementation(...) which returns the
> implementation hidden in the facades class. My advice is not to add your
> new method on the grid, as it is just a more specific version of the
> getRealImplementation method.
> 
> Besides this... why do you need these additional methods? If you
> consider them necessary, please open a feature-request and let
> everybody discuss this topic. I havent worked a lot with higher order
> transformations, but I never had the need to access these additional
> information from user code.
> 
> Christian
> 
>>
>> Regards,
>> Aleksejs
>>
>> _______________________________________________
>> Dune mailing list
>> Dune at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune
>>
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJU8IIwAAoJEDkNM7UOEwMZ37oP/iXkCTYzgK+/RdWKKKmsDLlq
IZZNu8KnDcO3vWMvOwCMmO3c/IEyEKp0hkNFto1LikK6xSxlsrv6Lq7THMOx2KPx
guGsLk7JsR4m7jhz74r4dJ3i2R9nRUiftzlt81ugV9RQH8NU/p76Xiywio3yAz2T
oFHua7fITIAqrOvhjZsorU/3c8Dr2fzcE0Mc5UuuIa1yGyDGmpKivisY7UOQO8sA
8KXEKcfJjEzgEX+gBnETg2Lka5qhAXAdpRpmvWxgwzgl7GAJCUJI9TDwxkS9I8cg
FZHeF1dNS4TD0CjOEplt19uw8dOzZIDq1lT+LEsF4pRVJV9aP7E0LWPdUins2JlI
g+dM9QQorx0zr9luhm0hujH3uTuOXVghMrAzr4ClzkwOzkRZRXXi0waYyUsP0sCB
OZCJN2cXFCw87delVq+i+6ElwBVHOTVUjdy00gOU0cvMlsnzetfmxcq10MlIGveY
d/EOUvPu6a0Vs0RG2NKbMRC/EnH1dnA7nz22NyrTLiXHB8Q+c+8ypRVMvIMVgVZA
PVBaP6WMqbEJAi1T42/TJXo16FvAlaYVNSDkqhZhYxaZjcuM4oKDlabAqbDMzsjY
z9aEcKQ/n2MXYMKCM1lCFFb2hHhJLmBCcxaAZkYRyFyBDq2L71tXU2PU31e4q8J9
KOBAzBi1Lg1k6TCLECRS
=yoU7
-----END PGP SIGNATURE-----



More information about the Dune mailing list