[Dune-devel] Broken compatibility for GenericReferenceElement*

[Oliver Sander]

Am 28.08.2013 17:14, schrieb Christoph Grüninger:
> Hi Oliver,

Hi Christoph,

> with your last two commits to dune-geometry you broke the compatibility mechanism for GenericReferenceElement* to ReferenceElement* name change. That was the only reason to include
> genericreferenceelements.hh.

I was half-expecting something like this.  But then: that ominous inclusion was not documented,
and all module tests still passed after my patch.  Can you please explain the mechanism?
Why does referenceelements.hh have to include genericreferenceelements.hh, if nothing from the
latter file is used?


>
> Sure, the deprecation warning did not work for the classes in the header, but now some programs do not compile at all. Let's try Bernd's advice and deprecate the constructor instead of the whole file.
> Can I first revert your two latest commits?

Compromise: you leave the #warning in and only revert the other commit?

--
Oliver

>
> Bye
> Christoph
>