[Dune-devel] Removes unused parameter warnings with -Wall -Wextra

[Markus Blatt]

On Mon, Dec 16, 2013 at 09:59:39AM +0100, Christoph Grüninger wrote:
> Hi Dune,
> do we really want to fix all unused parameters in Dune? As far as I know
> this is only triggered by setting -Wextra together with -Wall or
> -Wunused (at least for GCC). The flags from Wextra are known to emit
> false warnings.
> Enabling Wextra triggers other warnings that cannot be turned of.

Do I want to fix them? No. But do I want to have them fixed, yes.
> 
> I suggest to not fix these warnings and only fix warnings from sane
> settings. For me Wextra not sane.

-Wunused-parameter can help you find bugs and I know some mantainers
of modules that use DUNE that use them regularly and contribute rather
valuable bugfixes. I found several bugs with extra warnings
turned. Having them fixed in core DUNE just means saving other
people's time.

I see no reason, why I should not make people's live easier if I have
some free time left. Of course nobody _has_ _to_ fix these warnings,
but we should not prevent people fixing them.

Markus

-- 
Do you need more support with DUNE or HPC in general? 

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858  Fax: +49 (0)322 1108991658