[Dune-devel] cmake: set(HAVE_* *_FOUND) or set(HAVE_* ${*_FOUND})?

[Ansgar Burchardt]

Hi,

another problem I have with cmake is that sometimes

  set(HAVE_* *_FOUND)

is used instead of

  set(HAVE_* ${*_FOUND})

which causes config.h to contain -- for example --

  #define HAVE_PSURFACE PSURFACE_FOUND

which works if #ifdef HAVE_* is used, but not in places where #if HAVE_*
is used.

Should the following five occurences be changed to ${*_FOUND} or did I
miss something?

./dune-common/cmake/modules/FindUMFPack.cmake:set(HAVE_UMFPACK
UMFPACK_FOUND)
./dune-common/cmake/modules/DuneMPI.cmake:  set(HAVE_MPI MPI_CXX_FOUND)
./dune-grid/cmake/modules/FindPsurface.cmake:set(HAVE_PSURFACE
PSURFACE_FOUND)
./dune-pdelab/cmake/modules/UsePETSc.cmake:set(HAVE_PETSC PETSC_FOUND)
./dune-istl/cmake/modules/FindSuperLU.cmake:set(HAVE_SUPERLU SUPERLU_FOUND)

Ansgar

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20131220/d31aabec/attachment.sig>