[Dune-devel] [Dune-Commit] [Commit] dune-common - 532ec8e: added missing headers to Makefile.am

[Dedner, Andreas]

Hi Markus.
Your right - I wanted them in the tarball but as you said, they do not have to be installed, I did
not think of that difference....
I'll switch them to noinst as you suggest.
Best
Andreas
________________________________________
From: dune-devel-bounces+a.s.dedner=warwick.ac.uk at dune-project.org [dune-devel-bounces+a.s.dedner=warwick.ac.uk at dune-project.org] on behalf of Markus Blatt [markus at dr-blatt.de]
Sent: 06 July 2013 13:23
To: dune-devel at dune-project.org
Subject: Re: [Dune-devel] [Dune-Commit] [Commit] dune-common - 532ec8e: added missing headers to Makefile.am

Hi Andreas,

you added two headers (iteratorfacadetest.hh and dummyiterator.hh) to
testinclude_HEADERS. It seems like these headers are only used by
tests in this directory are not usable elsewhere.

Putting them in testinclude_HEADERS will not only distribute them but
also install them. Was this really your intention or would it suffice
to just distribute them with the tarballs? In this case it would
suffice to just add iteratorfacadetest.hh to noinst_HEADERS.

Cheers,

Markus

On Fri, Jul 05, 2013 at 10:45:09PM +0200, Andreas Dedner wrote:
> New commit, appeared at Fri Jul  5 22:45:09 2013 +0200
> as part of the following ref changes:
>
>     branch refs/heads/master    updated from 68ff9b7 -> 532ec8e
>
> Browsable version: http://cgit.dune-project.org/repositories/dune-common/commit/?id=532ec8e3ef09da384140d586ef8b64f69e7cf72e
>
> ======================================================================
>
> commit 532ec8e3ef09da384140d586ef8b64f69e7cf72e
> Author: Andreas Dedner <a.s.dedner at warwick.ac.uk>
> Date:   Fri Jul 5 21:34:42 2013 +0100
>
>     added missing headers to Makefile.am
>
>  dune/common/test/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>
> diff --git a/dune/common/test/Makefile.am b/dune/common/test/Makefile.am
> index 30aaefa..f65cbf1 100644
> --- a/dune/common/test/Makefile.am
> +++ b/dune/common/test/Makefile.am
> @@ -102,7 +102,7 @@ noinst_HEADERS = dummyiterator.hh
>
>  # Install some test headers, because they get used by tests in other modules
>  testincludedir = $(includedir)/dune/common/test
> -testinclude_HEADERS = checkmatrixinterface.hh iteratortest.hh
> +testinclude_HEADERS = checkmatrixinterface.hh iteratortest.hh iteratorfacadetest.hh dummyiterator.hh
>
>  # define the programs
>  pathtest_SOURCES = pathtest.cc
>
> _______________________________________________
> Dune-Commit mailing list
> Dune-Commit at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-commit
>

--
Do you need more support with DUNE or HPC in general?

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858  Fax: +49 (0)322 1108991658

_______________________________________________
Dune-devel mailing list
Dune-devel at dune-project.org
http://lists.dune-project.org/mailman/listinfo/dune-devel