[Dune-devel] Please review: pthread in dune/istl/paamg/test

[Christoph Grüninger]

Hi Markus,
can you review the attached patch? The pthread test did first
fail to link due to a missing underscore. Then I got 
"Ungültiger
Maschinenbefehl" and a compiler warning. I mimics the other,
not failing pthread test and now it works. With the patch it
works with CMake, too.
As this is not my field of expertise, I'd like to get a second
opinion.

Unrelated, but in the same folder: I still get deprecation
warnings for AMG which was deprecated in the last release. Can
you have a look?

amgtest.cc:134:7: warning: 'AMG' is deprecated 
[-Wdeprecated-declarations]
   AMG amg(fop, criterion, smootherArgs, 1, 1, 1, false);
       ^
amgtest.cc:179:3: note: in instantiation of function template 
specialization 'testAMG<1>' requested here
   testAMG<1>(N, coarsenTarget, ml);
   ^
../../../../dune/istl/paamg/amg.hh:153:7: note: 'AMG' declared 
here
       AMG(const Operator& fineOperator, const C& criterion,
       ^
amgtest.cc:134:7: warning: 'AMG' is deprecated 
[-Wdeprecated-declarations]
   AMG amg(fop, criterion, smootherArgs, 1, 1, 1, false);
       ^
amgtest.cc:180:3: note: in instantiation of function template 
specialization 'testAMG<2>' requested here
   testAMG<2>(N, coarsenTarget, ml);
   ^
../../../../dune/istl/paamg/amg.hh:153:7: note: 'AMG' declared 
here
       AMG(const Operator& fineOperator, const C& criterion,


Bye
Christoph

-- 
Die meisten Gebäude stammen aus einer Zeit, in der man auch
Türklinken aus Beton gemacht hätte, wenn das denn ginge.
[Spiegel Online, 25. Februar 2013]
*********************************************
CMWR 2014: 10th - 13th June 2014 in Stuttgart
          Please visit www.cmwr14.de
*********************************************
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-release-Fix-pthread-test.patch
Type: application/octet-stream
Size: 3091 bytes
Desc: not available
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20131122/1d6b4c5c/attachment.obj>