[Dune-devel] Please review: pthread in dune/istl/paamg/test

[Markus Blatt]

Hi,

On Fri, Nov 22, 2013 at 11:04:40PM +0100, Christoph Grüninger wrote:
> Hi Markus,
> can you review the attached patch? The pthread test did first
> fail to link due to a missing underscore. Then I got "Ungültiger
> Maschinenbefehl" and a compiler warning. 

looks OK to me, but I did not test it. (Having CFLAGS in LDFLAGS makes
abolutely no sense.) 


> I mimics the other,
> not failing pthread test and now it works. With the patch it
> works with CMake, too.

??? There are no changes to CMake in the patch, are there?

> As this is not my field of expertise, I'd like to get a second
> opinion.
> 
> Unrelated, but in the same folder: I still get deprecation
> warnings for AMG which was deprecated in the last release. Can
> you have a look?
> 

Currently, this has the lowest priority.

Markus

-- 
Do you need more support with DUNE or HPC in general? 

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858  Fax: +49 (0)322 1108991658