[Dune-devel] Yaspgrid Beautification
Oliver Sander
sander at igpm.rwth-aachen.de
Mon Oct 14 18:55:28 CEST 2013
Hi Dominic,
I had a quick look. There is now a new branch yaspgrid-as-tensorgrid-merge.
It contains the yaspgrid-as-tensorgrid branch rebased against master.
Some manual work was needed. The (sequential) grid test passes (didn't test
the other one yet), but valgrid gives a few warnings. That has to wait --
No time to look at that right now.
Yes I agree, this was not a good time for cleanup. But there are few occasions
for me nowadays to do those kind of things, and I just had to seize the
opportunity :-)
Cheers,
Oliver
Am 14.10.2013 16:47, schrieb Oliver Sander:
> Hi Dominic,
> don't despair -- git does almost all of the heavy lifting for you.
> You need to first merge master into the feature branch, and then you
> can continue from there. I'll have a look.
> Cheers,
> Oliver
>
>> I know I am bit late with this, but...
>> I was already wondering when I first heard and now that i had a look
>> into changes I am wondering even more: I told you all that i spent a
>> whole month working on uncommitted changes in yaspgrid this summer.
>> How can i possibly merge this into master when its finished without
>> rewriting it line by line??? The code is not only largely changed, but
>> moved to different headers! While I do understand why you want to
>> beautify the yaspgrid code, I am not very happy about the timing of
>> this. I am still working with markus until mid november, after that I
>> want to finish the stuff.
>> Best,
>> Dominic
>>
>
>
>
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 551 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20131014/6892a1bc/attachment.sig>
More information about the Dune-devel
mailing list