[Dune-devel] hash_combine on 32 bit

[Carsten Gräser]

Hi Steffen,

Am 23.10.2013 14:46, schrieb Steffen Müthing:
[...]
>> Do you know if this 32 bit variant is still reasonable?
> 
> you're right, the code is probably not correct for 32bit systems. I have
> a local patch with a 32bit version of the algorithm (also taken from
> CityHash), but it depends on a test for the size of size_t, and I don't
> know how to write that test for cmake. I've asked Christoph to take a
> look at that. Once the test works for cmake as well, I'll push the fix.
couldn't we just use template spezialization and sizeof(size_t)?
This would exploit that we already know this at compile time in
order to avoid another test.

Best,
Carsten


-- 
----------------------------------------------------------------------
Dr. Carsten Gräser       | phone: +49-30 / 838-75349
Freie Universität Berlin | fax  : +49-30 / 838-54977
Institut für Mathematik  | email: graeser at math.fu-berlin.de
Arnimallee 6             |
14195 Berlin, Germany    | URL  : http://page.mi.fu-berlin.de/graeser
----------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20131023/7a75bbd4/attachment.sig>