[Dune-devel] [GSoC] Update on the psurface

[Oliver Sander]

Hi Xiaoxue,
I have not received an answer from you for this mail.  Are you still working
on the stuff?
--
Oliver

Am 18.09.2013 12:02, schrieb Oliver Sander:
> Hi Xiaoxue,
> 
>>
>> Sorry for put psurfaceboundary.hh in the psurface folder. I have deleteded.
> 
> Thanks.
> 
> The Makefile.am still reference some nonexisting headers, e.g., pindent.hh and
> pcommon.hh.  Could you please remove those?  Otherwise psurface doesn't build.
> 
>> I have folked the dune-grid directoy on github to my directory(https://github.com/dune-project/dune-grid.git) and push the code there.
> 
> Must be me, but I can't find it.  Where is 'your directory'?
> 
>> In the same time, I have corrected some bugs in the psurface code. Could you pull the psurface code again?
>>
> 
>> I got cold last week so I did not have lots update. Now I am healthy again. Do you have new assignment for me this week?
> 
> I pulled your code and had a look at your code.  As suggested by Markus I think you should spend your last
> few days doing some polishing.  For example:
> 
> Remove the file psurface_convert_test.cpp, and put the code into psurface_convert.cpp
> 
> There are methods that return bool, but they always return the same values.
> Make the return void instead.
> 
> Use std::string instead of char* wherever possible.
> 
> Why does the PSurfaceConvert class copy all the data of the PSurface object it holds?
> Why can it not just use the data from the PSurface object directly?
> 
> The PSurfaceConvert class is very large, because it does many things.
> Can you factor hdf5 handling into a separate class and a separate file?
> Same for vtu?  Same for gmsh?
> 
> Some more documentation is always helpful.  I think that will be more than enough
> for the last days.
> 
> Good luck,
> Oliver
> 
>>
>>     Best,
>>     Oliver
>>
>>
>>         Best,
>>         Xiaoxue
>>
>>
>>         _________________________________________________
>>         Dune-devel mailing list
>>         Dune-devel at dune-project.org <mailto:Dune-devel at dune-project.org>
>>         http://lists.dune-project.org/__mailman/listinfo/dune-devel <http://lists.dune-project.org/mailman/listinfo/dune-devel>
>>
>>
>>
>>     _________________________________________________
>>     Dune-devel mailing list
>>     Dune-devel at dune-project.org <mailto:Dune-devel at dune-project.org>
>>     http://lists.dune-project.org/__mailman/listinfo/dune-devel <http://lists.dune-project.org/mailman/listinfo/dune-devel>
>>
>> Best,
>> Xiaoxue
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 551 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20130921/c5d65b8c/attachment.sig>