[Dune-devel] SGrid provides its DGFParser

[Oliver Sander]

Am 16.12.2014 um 12:49 schrieb Andreas Lauser:
> Hi,
> 
> On Tuesday 16 December 2014 12:20:33 Robert Kloefkorn wrote:
>>> What about deprecating the complete header
>>> dune/grid/io/file/dgfparser.hh
>>> and including the parsers directly to the grids where this is not yet
>>> the case? Then we can remove the inclusion of this header all together
>>> and see no deprecation warning any more.
>>
>> That is one possible solution that I think is ok. As I mentioned before,
>> I comes with a bias, the one that you cannot not include the DGFParser
>> anymore.
> 
> Actually, why is the SGrid class deprecated by adding a #warning to the header 
> file? I thought that the normal way was to add DUNE_DEPRECATE_MSG to its 
> constructors. (That way, it would only generate a warning if the class is 
> actually used and not by just including the header.)
> 

Because I find deprecating headers much more reliable than the __attribute__(deprecated)
machine.  And since everybody complains about long compile times I didn't expect
anybody to include sgrid.hh without actually using SGrid.

--
Oliver


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20141216/337dc38d/attachment.sig>