[Dune-devel] [Dune-Commit] [Commit] dune-istl - ae1cc4f: [CMake] Adjust find SuperLU script modifies ALL_PKG_LIBS property

[Dominic Kempf]

Hey Markus,

we did not add the DUNE_LIBS to the ALL_PKG_LIBS, but wrote the macro
add_dune_all_flags in a way, that it appends both DUNE_LIBS and
ALL_PKG_LIBS (in that order). This way the scenario you mention does not
come up. We were not sure whether people would expect the DUNE_LIBS to be
part of ALL_PKG_LIBS. If so, the find scripts should prepend the flags
instead of appending them.

Best,
Dominic

PS: When you proposed to get rid of all the package-specific flags and
macros, did you think of a mechanism like this one or something entirely
new?

On Tue, Dec 16, 2014 at 3:14 PM, Markus Blatt <markus at dr-blatt.de> wrote:
>
> Hi,
>
>
> On Tue, Dec 16, 2014 at 02:51:33PM +0100, Christoph Grüninger wrote:
> >
> > commit ae1cc4f56c999c8d17cb3c9d2b885706ef56a6cb
> > Author: Christoph Grüninger <gruenich at dune-project.org>
> > Date:   Tue Dec 16 14:51:06 2014 +0100
> >
> >     [CMake] Adjust find SuperLU script modifies ALL_PKG_LIBS property
> >
> >  cmake/modules/FindSuperLU.cmake | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >
> >
> > diff --git a/cmake/modules/FindSuperLU.cmake
> b/cmake/modules/FindSuperLU.cmake
> > index 28f4e45..4c96e4a 100644
> > --- a/cmake/modules/FindSuperLU.cmake
> > +++ b/cmake/modules/FindSuperLU.cmake
> > @@ -139,4 +139,6 @@ if(SUPERLU_FOUND)
> >    foreach(dir ${SUPERLU_INCLUDE_DIRS})
> >      set_property(GLOBAL APPEND PROPERTY ALL_PKG_FLAGS "-I${dir}")
> >    endforeach()
> > +  set_property(GLOBAL APPEND PROPERTY
> > +    ALL_PKG_LIBS "${SUPERLU_DUNE_LIBRARIES}")
> >  endif()
> >
>
> Aren't the libraries ending up in the wrong order here:
>
> package dune-a depends on package b, then we first search for b
> and then for dune-a which results in -lb -ldunea. That will not work
> with static linkage.
>
> Markus
> --
> Do you need more support with DUNE or HPC in general?
>
> Dr. Markus Blatt - HPC-Simulation-Software & Services
> http://www.dr-blatt.de
> Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
> Tel.: +49 (0) 160 97590858
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20141216/c74570e2/attachment.htm>