[Dune-devel] [Dune-Commit] [Commit] dune-istl - ae1cc4f: [CMake] Adjust find SuperLU script modifies ALL_PKG_LIBS property

[Markus Blatt]

On Tue, Dec 16, 2014 at 10:18:21PM +0100, Dominic Kempf wrote:
> Isnt the Parmetis - Metis dependency handled by the fact, that
> PARMETIS_LIBRARIES is set to "${PARMETIS_LIBRARY};${METIS_LIBRARY}"? This
> way, the parmetis library always appears before the metis library. This can
> be generalized as a rule: If a library depends on other external libraries,
> it has to enforce the order of the libs on the list of needed libraries
> before appending that list to ALL_PKG_LIBS.

Unfortunately, we are not living in a perfect world. There might be
cases where this is not done right and finding them when user modules
break might be fun.

I would create a macro dune_register_library that does this in a
fool-proof manner.

But I will stop arguing now

Markus

-- 
Do you need more support with DUNE or HPC in general? 

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
Tel.: +49 (0) 160 97590858
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20141217/dcf51433/attachment.sig>