[Dune-devel] ALUGrid with CMake brings in zlib dependency

[Markus Blatt]

Hi,

On Tue, Nov 25, 2014 at 08:20:11PM +0100, Christoph Grüninger wrote:
> From b4364009906729bff9ce5477f613e41634f04033 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Christoph=20Gr=C3=BCninger?= <gruenich at dune-project.org>
> Date: Tue, 25 Nov 2014 20:13:45 +0100
> Subject: [CMake] Add ZLIB_LIBRARIES to DUNE_LIBS.
> 
> libdunealugrid uses zlib and triggered liker errors
> in targets even without dune-alugrid dependencies.
> ---
>  cmake/modules/DuneAlugridMacros.cmake | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/cmake/modules/DuneAlugridMacros.cmake b/cmake/modules/DuneAlugridMacros.cmake
> index a01a629..38f73ed 100644
> --- a/cmake/modules/DuneAlugridMacros.cmake
> +++ b/cmake/modules/DuneAlugridMacros.cmake
> @@ -39,6 +39,8 @@ endforeach()
>  find_package(ZLIB)
>  #set HAVE_ZLIB for config.h
>  set(HAVE_ZLIB ${ZLIB_FOUND})
> +# append zlib to list of dune libraries
> +list(APPEND DUNE_LIBS ${ZLIB_LIBRARIES})

I would say that this is the wrong variable. It should probably go
into DUNE_MODULE_LIBRARIES such that it ends up in the package
configuration files (dune-alugrid-config.cmake) in variable
dune-alugrid_LIBRARIES.

Markus

-- 
Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany,  USt-Id: DE279960836
Tel.: +49 (0) 160 97590858
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20141126/901736d6/attachment.sig>