[Dune-devel] [Dune-Commit] [Commit] dune-common - 31625a0: Adjust fmatrixtest to use initializer lists.

[Dominic Kempf]

Okay, I agree I was overeager. I guess this was the result of the
combination of
a) my discontent with the status quo of those tests breaking the
dune-common tests on cmake (although this issue could be solved in similar
fashion as the debugallocatortests I fixed afterwards)
b) my surprise about the existence of such code and the fact, that it was
not used a single time outside the unit tests testing that very same code.
(Would have expected it in istl tests)
But if you want to stick with it, I will revert the removal of the tests.

Dominic

On Mon, Oct 13, 2014 at 4:51 PM, Christoph Grüninger <
christoph.grueninger at iws.uni-stuttgart.de> wrote:

> Hi Markus,
> hi Dominic,
>
> we can reintroduce the test code and surround it by
> a DISABLE_DEPRECATED_METHOD_CHECK. If this macro is set
> we can return exit code 77.
>
> Would this be acceptable for Dune 2.4?
>
> Bye
> Christoph
>
>
>  Hi,
>>
>> On Wed, Oct 08, 2014 at 10:30:46AM +0200, Dominic Kempf wrote:
>>
>>> New commit, appeared at Wed Oct  8 10:30:46 2014 +0200
>>> as part of the following ref changes:
>>>
>>>     branch refs/heads/master    updated from 650370a -> 275c824
>>>
>>> Browsable version: http://cgit.dune-project.org/
>>> repositories/dune-common/commit/?id=31625a0b94688239c8045c2e6fd689
>>> daa91d7872
>>>
>>> ======================================================================
>>>
>>> commit 31625a0b94688239c8045c2e6fd689daa91d7872
>>> Author: Dominic Kempf <dominic.kempf at iwr.uni-heidelberg.de>
>>> Date:   Mon Oct 6 14:31:04 2014 +0200
>>>
>>>     Adjust fmatrixtest to use initializer lists.
>>>
>>>  dune/common/test/fmatrixtest.cc | 26 ++++++++++++--------------
>>>  1 file changed, 12 insertions(+), 14 deletions(-)
>>>
>>>
>>>
>>> diff --git a/dune/common/test/fmatrixtest.cc b/dune/common/test/
>>> fmatrixtest.cc
>>> index 48e659c..3db6a9a 100644
>>> --- a/dune/common/test/fmatrixtest.cc
>>> +++ b/dune/common/test/fmatrixtest.cc
>>> @@ -8,7 +8,6 @@
>>>  #define DUNE_ISTL_WITH_CHECKING
>>>  #endif
>>>  #include <dune/common/fmatrix.hh>
>>> -#include <dune/common/fassign.hh>
>>>  #include <dune/common/classname.hh>
>>>  #include <iostream>
>>>  #include <algorithm>
>>> @@ -452,16 +451,16 @@ void test_ev()
>>>     * A small, nonzero eigenvalue
>>>      */
>>> -  Dune::FieldMatrix<ft,8,8> A;
>>> -  A <<=
>>> -    611, 196, -192, 407, -8, -52, -49, 29, Dune::nextRow,
>>> [...]
>>>
>>
>> actually this is a bit overeager. IMHO even deprecated features should
>> and need to be tested in addition to the new interface. Otherwise
>> there is no way that we can be sure about their functionality.
>>
>> Cheers,
>>
>> Markus
>>
>
>
> --
> Das Kommt darauf an, in welchen Zeiträumen du
> rechnest. Für Geologen: ja, in naher Zukunft
> [Stefan Seyfried in suse-laptop]
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20141013/f3ff36d6/attachment.htm>