[Dune-devel] Adding extra CXXFLAGS upon calling make with the cmake buildsystem

[Dominic Kempf]

Hey Christian,

I don't get exactly what you are proposing here, because
1) the script doesn't has to be modified, because it is generated by the
build system upon configuration.
2) Changing the compiler without reconfiguring isn't supported by cmake
anyway.

Andreas, I am hesitant about merging, as I think, there might be some
scenarios, where this will bite you. I am not (yet) able to name one such
scenario though. But you are right, users not setting the flag are 100%
free of side effects.

Dominic

On Wed, Sep 24, 2014 at 2:25 PM, Christian Engwer <
christian.engwer at uni-muenster.de> wrote:

> One comment...
> shouldn't we do it in such a way that the compiler command is
>   compiler.sh $CXX
> ?
>
> In this case it would not be necessary to modify the script when
> specifying the compiler, or did  I read the commit wrong?
>
> Christian
>
> On Wed, Sep 24, 2014 at 01:20:03PM +0200, Dominic Kempf wrote:
> > I made a typo (it should be CMAKE_FLAGS) in the "manual".
> >
> > I amended that and then realized, this changes the ref. please see this
> > link, instead of above:
> >
> http://cgit.dune-project.org/repositories/dune-common/commit/?h=p/dominic/allow-extra-cppflags-in-cmake&id=f578610b3648e55bf7e5f7aaaef6c3c46468533a
> >
> > Dominic
> >
> > On Wed, Sep 24, 2014 at 11:58 AM, Dominic Kempf <
> dominic.r.kempf at gmail.com>
> > wrote:
> >
> > > Hey Dune,
> > >
> > > the feature to add compile flags when running make seems to be of great
> > > importance to a lot of autotools users. This is conceptionally
> impossible
> > > to integrate in cmake. We have thought of a hack, that does the trick
> > > anyway.
> > >
> > > I am not sure whether this should actually be merged, as it is rather
> > > dirty. On the other hand, it doesn't do any harm, as it does nothing
> if not
> > > specifically switched on. For details on how to use it, check the
> commit:
> > >
> > >
> > >
> http://cgit.dune-project.org/repositories/dune-common/commit/?h=p/dominic/allow-extra-cppflags-in-cmake&id=dbccc31548c3347d21712d3f808ad4ccb4895b5d
> > >
> > > Enjoy!
> > > Dominic
> > >
>
> > _______________________________________________
> > Dune-devel mailing list
> > Dune-devel at dune-project.org
> > http://lists.dune-project.org/mailman/listinfo/dune-devel
>
>
> --
> Prof. Dr. Christian Engwer
> Institut für Numerische und Angewandte Mathematik
> Fachbereich Mathematik und Informatik der Universität Münster
> Einsteinstrasse 62
> 48149 Münster
>
> E-Mail  christian.engwer at uni-muenster.de
> Telefon +49 251 83-35067
> FAX             +49 251 83-32729
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20140924/2658372b/attachment.htm>