[Dune-devel] [Dune] change to inheritance of vtksequencewriter

Andreas Dedner a.s.dedner at warwick.ac.uk
Fri Sep 26 09:57:50 CEST 2014


> Hi Andreas,
> you are correct, I hadn't noticed this myself:
> The CRTP is a recent addition from May 7th of this year.  Have a look at
>
> 246bc56f6f3ec0994ca2fd85d84ea42fd6c27119
>
> which introduces a second base class VTKSequenceWriterBase, and makes
> VTKSequenceWriter inherit from that with CRTP.
>
> Best,
> Oliver
>
Ok that change seems reasonale and if the common base class is
achievable with CRPT then
whats the problem?

Basically I don't understand e why I have to argue this issue to this
extend. A change was made that
breaks code because it is not backwards compatible, I have to change my
code (and that of my
students) to get things to compile and I have to argue why it is should
be reverted?
As far as I can see no new feature was added or bug fixed, its only that
ypu find this non backwards compatible
change aesthetically more pleasing.. Could you please give me a better
reason?
Andreas





More information about the Dune-devel mailing list