[Dune-devel] [Dune] change to inheritance of vtksequencewriter

[Oliver Sander]

Am 25.09.2014 um 22:48 schrieb Andreas Dedner:
> 
>> It would still be restricted to VTK: it writes a .pvd file after all, which is VTK.
>> So I'd rather like to keep the name.
>>
>> I'm still thinking about whether there is a smoother way to introduce the new structure
>> without having to reintroduce the CRTP code.  Still unsure.
> What exactly do you mean? I looked into the release and there the
> VTKSequenceWriter was simply
> inheriting from VTKWriter no CRTP or anything like that, only
>   template< class GridView >
>   class VTKSequenceWriter : public VTKWriter<GridView> {
> So what is your issue with that - except that you don't think that the
> SequenceWriter is a Writer....
> Andreas
> 

Hi Andreas,
you are correct, I hadn't noticed this myself:
The CRTP is a recent addition from May 7th of this year.  Have a look at

246bc56f6f3ec0994ca2fd85d84ea42fd6c27119

which introduces a second base class VTKSequenceWriterBase, and makes
VTKSequenceWriter inherit from that with CRTP.

Best,
Oliver

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20140926/a9d133b8/attachment.sig>