[Dune-devel] [Dune-Commit] [Commit] dune-common - 21dbaef: [release] Make finding *.la files non-fatal.

[Christian Engwer]

Hi Markus,

I'm a bit surprised by this commit. The la files are something that
really breaks code. In particular, if you have downstream modules,
wich still use autotools, these modules will pick up old
configurations from the la files.

I agree that in 2.4 we don't want to force people, but to master we
are on the way to a cmake-only system, thus la files are something we
should not not find at all?!

Christian

On Mon, Aug 24, 2015 at 02:15:01PM +0200, Markus Blatt wrote:
> New commit, appeared at Mon Aug 24 14:15:01 2015 +0200
> as part of the following ref changes:
> 
>     branch refs/heads/master    updated from 6121bbd -> 21dbaef
> 
> Browsable version: http://cgit.dune-project.org/repositories/dune-common/commit/?id=21dbaefe75b761ab6ade8ccf73e33ba35b0c66b3
> 
> ======================================================================
> 
> commit 21dbaefe75b761ab6ade8ccf73e33ba35b0c66b3
> Author: Markus Blatt <markus at dr-blatt.de>
> Date:   Mon Aug 24 14:13:27 2015 +0200
> 
>     [release] Make finding *.la files non-fatal.
>     
>     Actually, having these files lying around does not hurt us.
>     In addition there are downstream modules that especially create
>     these for compatibility reasons with autotools. For these
>     reconfiguring a module using dunecontrol currently aborts with an error
>     
>     Therefore this commit resorts to just issuing a warning and proceeding
>     with the compilation instead of aborting with an error.
> 
>  bin/dunecontrol | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> 
> 
> diff --git a/bin/dunecontrol b/bin/dunecontrol
> index b8d222a..224ccb1 100755
> --- a/bin/dunecontrol
> +++ b/bin/dunecontrol
> @@ -717,8 +717,7 @@ run_default_configure () {
>        cd "$ABS_BUILDDIR"
>        # check for libtool libs, which might break modules depending on this module
>        test -n "`find . -name \*.la`" && \
> -          echo "Error: your build directory $ABS_BUILDDIR contains libtool built libraries, please cleanup" && \
> -          exit 1
> +          echo "Warning: your build directory $ABS_BUILDDIR contains libtool built libraries, please cleanup"
>        echo "$PREPARAMS $CMAKE -DCMAKE_MODULE_PATH=\"$CMAKE_MODULE_PATH\" $CMAKE_PARAMS $CMAKE_FLAGS \"$SRCDIR\""
>        eval $PREPARAMS $CMAKE "-DCMAKE_MODULE_PATH=\"$CMAKE_MODULE_PATH\" $CMAKE_PARAMS $CMAKE_FLAGS \"$SRCDIR\"" || exit 1
>      else
> 
> _______________________________________________
> Dune-Commit mailing list
> Dune-Commit at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-commit
> 

-- 
Prof. Dr. Christian Engwer 
Institut für Numerische und Angewandte Mathematik
Fachbereich Mathematik und Informatik der Universität Münster
Einsteinstrasse 62
48149 Münster

E-Mail	christian.engwer at uni-muenster.de
Telefon	+49 251 83-35067
FAX		+49 251 83-32729