[Dune-devel] d35ee0d [bugfix, release] Fix the checkInside method for subentities

Martin Nolte nolte at mathematik.uni-freiburg.de
Thu Jul 2 14:20:45 CEST 2015


I guess this is my fault - sorry.

But: If nobody actually uses the method, then let's deprecate it in the release 
and directly get rid of it. It is pure syntactial sugar anyway.

Best,

Martin

On 07/02/2015 02:12 PM, Oliver Sander wrote:
> commit d35ee0da58bc50762eb079e6bc1f6595f98b1de7
> Author: Oliver Sander <sander at igpm.rwth-aachen.de>
> Date: Thu, 2 Jul 2015 14:12:56 +0200
>
> [bugfix,release] Fix the checkInside method for subentities
>
> Rather surprisingly, the checkInside method for subentities was completely
> broken. One of the template parameters was wrong, and you'd get a compiler
> error as soon as you'd use the method for a codim>0 subentity.
>
> The method has been like that at least since 2012, which makes me suspect
> that nobody actually needs it. I don't -- I just stumbled across the bug
> by accident.
>
> M dune/geometry/referenceelements.hh
>

-- 
Dr. Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5630
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany




More information about the Dune-devel mailing list