[Dune-devel] d35ee0d [bugfix, release] Fix the checkInside method for subentities

[Oliver Sander]

Am 02.07.2015 um 14:20 schrieb Martin Nolte:
> I guess this is my fault - sorry.
> 
> But: If nobody actually uses the method, then let's deprecate it in the release and directly get rid of it. It is pure syntactial sugar anyway.

+1
Or just kill it right away.  We have proof that nobody uses it.

Best,
Oliver

> 
> Best,
> 
> Martin
> 
> On 07/02/2015 02:12 PM, Oliver Sander wrote:
>> commit d35ee0da58bc50762eb079e6bc1f6595f98b1de7
>> Author: Oliver Sander <sander at igpm.rwth-aachen.de>
>> Date: Thu, 2 Jul 2015 14:12:56 +0200
>>
>> [bugfix,release] Fix the checkInside method for subentities
>>
>> Rather surprisingly, the checkInside method for subentities was completely
>> broken. One of the template parameters was wrong, and you'd get a compiler
>> error as soon as you'd use the method for a codim>0 subentity.
>>
>> The method has been like that at least since 2012, which makes me suspect
>> that nobody actually needs it. I don't -- I just stumbled across the bug
>> by accident.
>>
>> M dune/geometry/referenceelements.hh
>>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20150702/2674769a/attachment.sig>