[Dune-devel] 2ec7fbb [TypeIndex] Make GlobalGeometryTypeIndex::base() public

[Martin Nolte]

On 10/12/2015 02:15 PM, Steffen Müthing wrote:
> Hi Martin,
>
>
>> Am 12.10.2015 um 13:55 schrieb Martin Nolte <nolte at mathematik.uni-freiburg.de>:
>>
>> Hi Steffen,
>>
>> would you consider giving a meaningful name to the method once it is public?
>
> sure, we can do that. I’m bad at names, how about dimensionOffset()?
Fine with me. I guess even 'offset' would be sufficient. Only the name 'base' 
was pretty unintuitive to me.

Best,

Martin

>
>>
>> Moreover, I am not sure whether you can actually use this method in combination with the index method.
>
> If you wanted to use it for indexing, you would have to use it with LocalGeometryTypeIndex::index(), but I
> actually just want the dimension offset to look into per-GeometryType offset arrays. In theory, I could write
> GlobalGeometryTypeIndex::size(dim - 1), but that isn’t really readable (and maybe problematic if dim == 0).
>
> Steffen
>
>>
>> Best,
>>
>> Martin
>>
>> On 10/12/2015 01:48 PM, Steffen Müthing wrote:
>>> commit 2ec7fbbd20db66fa1aacaf7eda94424ee6f13c20
>>> Author: Steffen Müthing <muething at dune-project.org>
>>> Date: Mon, 12 Oct 2015 13:48:14 +0200
>>>
>>> [TypeIndex] Make GlobalGeometryTypeIndex::base() public
>>>
>>> It's a useful method (and required by PDELab), so make it publicly
>>> available.
>>>
>>> M dune/geometry/typeindex.hh
>>>
>>
>> --
>> Dr. Martin Nolte <nolte at mathematik.uni-freiburg.de>
>>
>> Universität Freiburg                                   phone: +49-761-203-5630
>> Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
>> Hermann-Herder-Straße 10
>> 79104 Freiburg, Germany
>>
>> _______________________________________________
>> Dune-devel mailing list
>> Dune-devel at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-devel
>>
>

-- 
Dr. Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5630
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany