[Dune-devel] First candidate for upcoming release 2.8.0 available for testing

[Markus Blatt]

On Fri, Aug 27, 2021 at 01:22:28PM +0200, Christian Engwer wrote:
>Dropping FindTBB fixed the compilation issue, so we most likely have
>an other success. We currently don't have run further tests, but it
>does look good.

Not so sure about that. I am still struggeling:

- I tried to call this FindTBB.cmake in OPM, but suddenly pkg-config has
  problems to resolve libatomic:

  In dune-common I have:
  TBB_FIND_VERSION=
  -- Checking for module 'tbb'
  --   Found tbb, version 
  CMAKE_PREFIX_PATH=
  PKG_CONFIG_PATH=
  PkgConfigTBB_LIBRARIES=tbb;atomic
  PkgConfigTBB_LINK_LIBRARIES=/usr/lib/x86_64-linux-gnu/libtbb.so;atomic PkgConfigTBB_FOUND=1 PkgConfig_FOUND=TRUE
  -- Found TBB: /usr/lib/x86_64-linux-gnu/libtbb.so;atomic (found version "") 

  and later in OPM:
  TBB_FIND_VERSION=
  -- Checking for module 'tbb'
  --   Found tbb, version 
  CMAKE_PREFIX_PATH=
  PKG_CONFIG_PATH=
  PkgConfigTBB_LIBRARIES=tbb;atomic
  PkgConfigTBB_LINK_LIBRARIES=/usr/lib/x86_64-linux-gnu/libtbb.so;pkgcfg_lib_PkgConfigTBB_atomic-NOTFOUND PkgConfigTBB_FOUND=1 PkgConfig_FOUND=TRUE
  -- Could NOT find TBB (set TBB_DIR to path containing TBBConfig.cmake or set PKG_CONFIG_PATH to include the location of the tbb.pc file) (missing: PkgConfigTBB_LINK_LIBRARIES) (found version "")

I was a bit clueless... but now I see that DUNE is shipping FindPkgConfig.cmake from CMake 3.19.4. Arrghh... not very nice. That is not even
in Debian stable which just got released. (but if you look at how many FindTBB.cmake exist in Debian stable ...)


>
>Ciao
>Christian
>
>Am Fri, Aug 27, 2021 at 01:14:21PM +0200 schrieb Christian Engwer:
>> Hi Markus,
>>
>> > You guys ship your own FindTBB.cmake and that does not define any imported target.
>> > The problem is that the imported targets defined by the module in dune-common
>> > are used on the linker lines that the core modules export.
>>
>> Yes, this changed with the 2.8 cmake cleanup.
>>
>> > Either use the upstream FindTBB.cmake (by removing your own) or define the same
>> > imported targets in your version of FindTBB.cmake.
>>
>> omg. you are absolutely right. Apparently this FindTBB is an artifact.
>> When we started using TBB the test was not yet in dune-common, but
>> only in the EXA-DUNE branches. I'll have to check, since when this
>> test is available, but I guess we can simply drop the file.
>>
>> Is there any chance to prioritize dune-common over duneuro.
>>
>> > BTW you might want/need to change the minimum required CMake version. It is still
>> > 2.8.6.
>>
>> I'm wondering how do we do all this in a backwards compatible
>> fashion. We would like to support 2.6 - 2.8, which works relatively
>> fine regarding C++, but I have the feeling that cmake will become more
>> and more an issue.
>>
>> Ciao
>> Christian
>>
>> _______________________________________________
>> Dune-devel mailing list
>> Dune-devel at lists.dune-project.org
>> https://lists.dune-project.org/mailman/listinfo/dune-devel
>
>-- 
>Prof. Dr. Christian Engwer
>Institut für Numerische und Angewandte Mathematik
>Fachbereich Mathematik und Informatik der Universität Münster
>Einsteinstrasse 62
>48149 Münster
>
>E-Mail  christian.engwer at uni-muenster.de
>Telefon +49 251 83-35067
>FAX     +49 251 83-32729
>
>_______________________________________________
>Dune-devel mailing list
>Dune-devel at lists.dune-project.org
>https://lists.dune-project.org/mailman/listinfo/dune-devel

-- 

Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Pedettistr. 38, 85072 Eichstätt, Germany
Tel.: +49 (0) 160 97590858