[Dune-devel] WG: Re: Nightly tests still using Ubuntu 18.04

[Dedner, Andreas]

Alternative: we find a way to manually run downstream pipelines, maybe
not only in dune-common but also in other core modules. Maybe we can run
these jobs automatically if a branch is merged into the master branch.
This is the important situation to test everything, we might not want to
test all downstream modules for each uploaded commit. This needs some
improvement of the gitlab-ci file.

Hi.
I would say that we shouldn't run the whole test suite for every commit - ruinning the CI
for every single commit is questionable anyway from a energy perspective especially for 'Draft' MRs.
Not allowing merges into master if downstream module testing fails might be worth exploring.
It can of course slow down development if a downstream module is failing for some unrelated reason though.
Best
Andreas
________________________________
From: Dune-devel <dune-devel-bounces at lists.dune-project.org> on behalf of Simon Praetorius <simon.praetorius at tu-dresden.de>
Sent: 25 November 2022 08:52
To: dune-devel at lists.dune-project.org <dune-devel at lists.dune-project.org>
Subject: [Dune-devel] WG: Re: Nightly tests still using Ubuntu 18.04


Sorry. My answer was sent only to Christoph, yesterday.


---- Originalnachricht ----
Betreff: Re: [Dune-devel] Nightly tests still using Ubuntu 18.04
Gesendet: 24.11.2022 23:55
Von: Simon Praetorius <simon.praetorius at tu-dresden.de>
An: Christoph Grüninger <foss at grueninger.de>
Cc:

Hi Christoph,

The nightly tests are not yet aligned with the compiler version changes
in the core modules. This will be done.

The failing pipeline is due to an (already fixed) typo in the recent
change of FindSuiteSparse.cmake. I have overlooked the position of an
underscore.

We should, however, update our gitlabci in dune-common regarding the
downstream test. Suggestions:

- We remove the flag "allow_failure". This has the effect, that e.g.
"merge on passed pipeline" does not merge in case of downstream failures
- We increase the list of tested downstream modules to the same list as
in the nightly tests, maybe with anything outside the core modules with
"allow_failure"

Alternative: we find a way to manually run downstream pipelines, maybe
not only in dune-common but also in other core modules. Maybe we can run
these jobs automatically if a branch is merged into the master branch.
This is the important situation to test everything, we might not want to
test all downstream modules for each uploaded commit. This needs some
improvement of the gitlab-ci file.

Best,
Simon

Am 24.11.22 um 23:36 schrieb Christoph Grüninger:
> Dear Andreas,
> dear Simon,
>
> our nightly tests still using Ubuntu 18.04. Currently dune-istl fails,
> probably because a change broke (with full intention) Clang++ 5.0.
> You adjusted the CI images. Can you please have look there, too?
>
> One of the failing build pipelines:
> https://gitlab.dune-project.org/infrastructure/dune-nightly-test/-/pipelines/55585
>
>
> Bye
> Christoph
>
--
Dr. Simon Praetorius
Technische Universität Dresden
Institute of Scientific Computing
phone: +49 351 463-34432
mail: simon.praetorius@​tu-dresden.de

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-devel/attachments/20221125/2dab7bd2/attachment-0001.htm>