[dune-pdelab] headercheck fails

[Christian Engwer]

On Mon, Oct 31, 2011 at 04:09:31PM +0100, Christoph Grüninger wrote:
> Dear PDELab,
> my quest for non-failing check/headercheck in Dune reached PDELab.
> Attached you find two patches.
> The smaller one adds a PETsc guard to a Makefile.am, otherwise make
> check fails for missing PETsc.
> The other patch adds some failing headers and excludes
> test/typetree*.hh from the headercheck. I don't understand the
> presence of typetreetestutility.hh. It does not compile for me and
> is nowhere included.

It is included in the tests, but nevertheless I think it is OK to
ignore these headers, as they are no _real_ headers, but used in the
tests.

> Thanks for having a look
> Christoph
> 
> -- 
> Since we don’t even know whether these solutions [to the Navier-
> Stokes equation] exist, our understanding is at a very primitive
> level. Standard methods from PDE appear inadequate to settle the
> problem. Instead, we probably need some deep, new ideas.
> [Charles L. Fefferman, US-Mathematiker, 2006]

> Index: dune/pdelab/test/Makefile.am
> ===================================================================
> --- dune/pdelab/test/Makefile.am	(Revision 1663)
> +++ dune/pdelab/test/Makefile.am	(Arbeitskopie)
> @@ -51,6 +51,11 @@
>  noinst_SCRIPTS =				\
>  	make_pvd.sh
>  
> +headercheck_IGNORE =				\
> +        typetreetargetnodes.hh			\
> +        typetreetestswitch.hh			\
> +        typetreetestutility.hh
> +
>  GRIDDIM = 2
>  
>  # scripts are not distributed automatically
> Index: dune/pdelab/gridoperator/onestep/prestageengine.hh
> ===================================================================
> --- dune/pdelab/gridoperator/onestep/prestageengine.hh	(Revision 1663)
> +++ dune/pdelab/gridoperator/onestep/prestageengine.hh	(Arbeitskopie)
> @@ -2,6 +2,7 @@
>  #define DUNE_PDELAB_ONESTEP_PRESTAGEENGINE_HH
>  
>  #include <dune/pdelab/gridoperator/onestep/enginebase.hh>
> +#include <cmath>
>  #include <vector>
>  
>  namespace Dune{
> Index: dune/pdelab/localoperator/stokesdgparameter.hh
> ===================================================================
> --- dune/pdelab/localoperator/stokesdgparameter.hh	(Revision 1663)
> +++ dune/pdelab/localoperator/stokesdgparameter.hh	(Arbeitskopie)
> @@ -1,6 +1,10 @@
>  #ifndef DUNE_PDELAB_LOCALOPERATOR_STOKESDGPARAMETER_HH
>  #define DUNE_PDELAB_LOCALOPERATOR_STOKESDGPARAMETER_HH
>  
> +#include <dune/common/parametertreeparser.hh>
> +
> +#include <dune/pdelab/common/geometrywrapper.hh>
> +
>  #include "stokesparameter.hh"
>  
>  namespace Dune {
> Index: dune/pdelab/gridfunctionspace/localfunctionspace.hh
> ===================================================================
> --- dune/pdelab/gridfunctionspace/localfunctionspace.hh	(Revision 1663)
> +++ dune/pdelab/gridfunctionspace/localfunctionspace.hh	(Arbeitskopie)
> @@ -7,6 +7,8 @@
>  
>  #include <dune/common/stdstreams.hh>
>  
> +#include <dune/grid/common/genericreferenceelements.hh>
> +
>  #include <dune/localfunctions/common/interfaceswitch.hh>
>  
>  #include <dune/pdelab/common/typetree.hh>

> Index: dune/pdelab/test/Makefile.am
> ===================================================================
> --- dune/pdelab/test/Makefile.am	(Revision 1650)
> +++ dune/pdelab/test/Makefile.am	(Arbeitskopie)
> @@ -323,11 +323,13 @@
>  testproxynode_SOURCES = testproxynode.cc
>  testproxynode_CPPFLAGS = $(AM_CPPFLAGS) -DTEST_TYPETREE
>  
> +if PETSC
>  check_PROGRAMS += testpoisson-petsc
>  testpoisson_petsc_SOURCES = testpoisson-petsc.cc
>  testpoisson_petsc_CPPFLAGS = @AM_CPPFLAGS@ $(PETSC_CPPFLAGS)
>  testpoisson_petsc_LDFLAGS = $(AM_LDFLAGS) $(PETSC_LDFLAGS)
>  testpoisson_petsc_LDADD = $(LDADD) $(PETSC_LIBS)
> +endif
>  
>  MOSTLYCLEANFILES += poisson_petsc_*.vtu
>  

> _______________________________________________
> dune-pdelab mailing list
> dune-pdelab at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-pdelab