[dune-pdelab] Build Error in PDELab-Howto (Debug mode) with dune-pdelab at df05cda

[Steffen Müthing]

Hi Bård,

Am 10.12.2013 um 18:01 schrieb Bård Skaflestad:

> All,
> 
> I get a build error in several examples in the PDELab-Howto in debug
> mode (symbol NDEBUG *not* defined) with recent commit df05cda to
> dune-pdelab's file.
> 
>        dune/pdelab/adaptivity/adaptivity.hh
> 
> I've narrowed the direct cause down to the following statement in that
> file (line 59, LeafOffsetCache<>::update())
> 
>        assert(leaf_offsets.back() == lfs.size());
> 
> If I blindly apply the change below to adaptivity.hh, then the build
> goes through.  However, this is informed only by localised code reading
> and does not include any further analysis for correctness or
> applicability.

thanks for reporting the problem. That was my fault, I moved some code
around and forgot to run the code without NDEBUG afterwards, so the
compile error in the assertion slipped through.

I applied your fix to master.

Thanks again,
Steffen

> 
> 
> Best regards,
> 
> Bård
> 
> -----------------------------------------------------------------------
> 
> diff --git a/dune/pdelab/adaptivity/adaptivity.hh
> b/dune/pdelab/adaptivity/adaptivity.hh
> index ac41f5b..3611bb3 100644
> --- a/dune/pdelab/adaptivity/adaptivity.hh
> +++ b/dune/pdelab/adaptivity/adaptivity.hh
> @@ -56,7 +56,7 @@ namespace Dune {
>             // convert to offsets
> 
> std::partial_sum(leaf_offsets.begin(),leaf_offsets.end(),leaf_offsets.begin());
>             // sanity check
> -            assert(leaf_offsets.back() == lfs.size());
> +            assert(leaf_offsets.back() == _lfs.size());
>           }
>       }
> 
> 
> 
> _______________________________________________
> dune-pdelab mailing list
> dune-pdelab at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-pdelab

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://lists.dune-project.org/pipermail/dune-pdelab/attachments/20131210/2234ecae/attachment.sig>