[dune-pdelab] Issues in 2.0-rc1

[Steffen Müthing]

Hi Christoph,

Am 10.06.2014 um 07:38 schrieb Christoph Grüninger <christoph.grueninger at iws.uni-stuttgart.de>:

> Hi Steffen,
> thanks for preparing a release candidate. I had some issues regarding
> make headercheck and with CMake in make check. I have not yet found
> the time to prepare proper patches. I hope I can do so until the end
> of the week.
> I attached was I changed so far.

thanks for the patches! I already fixed a couple of problems in the meantime, mostly header files
that weren’t listed in Makefile.am or CMakeLists.txt.

I’ll take a look at your changes and apply what seems reasonable (I’ll probably keep the error for
the Eigen backend, though. IMHO the proper fix is to use a conditional in the build system to avoid
problems there…).

There will probably be a second set of release candidates later today, this time with tar balls and an
announcement on the list.

Steffen

> 
> Bye
> Christoph
> 
> diff --git a/dune/pdelab/backend/eigen/descriptors.hh b/dune/pdelab/backend/eigen/descriptors.hh
> index 8b3790e..b61a760 100644
> --- a/dune/pdelab/backend/eigen/descriptors.hh
> +++ b/dune/pdelab/backend/eigen/descriptors.hh
> @@ -91,7 +91,7 @@ namespace Dune {
> } // namespace Dune
>  #else
> -#error You need Eigen to use the Eigen backend
> +#warning You need Eigen to use the Eigen backend
> #endif // HAVE_EIGEN
>  #endif // DUNE_PDELAB_BACKEND_EIGEN_DESCRIPTORS_HH
> diff --git a/dune/pdelab/backend/eigen/solvers.hh b/dune/pdelab/backend/eigen/solvers.hh
> index 70a249b..7c97b33 100644
> --- a/dune/pdelab/backend/eigen/solvers.hh
> +++ b/dune/pdelab/backend/eigen/solvers.hh
> @@ -8,7 +8,7 @@
>  #include <dune/pdelab/constraints/common/constraints.hh>
> -#include "solver.hh"
> +#include "../solver.hh"
>  #if HAVE_EIGEN
> diff --git a/dune/pdelab/backend/simple/descriptors.hh b/dune/pdelab/backend/simple/descriptors.hh
> index 62f59df..89b2330 100644
> --- a/dune/pdelab/backend/simple/descriptors.hh
> +++ b/dune/pdelab/backend/simple/descriptors.hh
> @@ -5,6 +5,8 @@
>  #include <vector>
> +#include <dune/pdelab/ordering/orderingbase.hh>
> +
> namespace Dune {
>   namespace PDELab {
> 
> _______________________________________________
> dune-pdelab mailing list
> dune-pdelab at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-pdelab

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://lists.dune-project.org/pipermail/dune-pdelab/attachments/20140610/136303bc/attachment.sig>