[dune-pdelab] Cleanup in pkqkfem.hh [patch]

[Oliver Sander]

Hi,

Am 16.06.2015 um 08:49 schrieb Christian Engwer:
> Hi Oli,
> 
> a) is great

Thanks.

> b) changes the interface, thus I won't commit it atm

Out of curiosity: how am I supposed to know that it is part of an official
interface?  Some FiniteElementMaps implement the method, others don't.
In particular, the classes in finiteelementmap.hh don't seem to have it.

> c) only remove the warning, but there is a general effort to cleanup
>    the local operators. The required  changes are described in
>    http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/issues/5

I will have a look.

Bye,
Oliver

>    in particular the copied objects should be obtained once and reused
>    afterwards to avoid unnecessary copies. Thus I'll not apply that
>    patch, as it only calms the compiler, but doesn't actually fix the
>    issues.
> 
> Ciao
> Christian
> 
> On Tue, Jun 16, 2015 at 07:52:57AM +0200, Oliver Sander wrote:
>> Dear pdelab team,
>> no reaction so far.  Is there anything I can do to help get these patches
>> reviewed and merged?
>> Thanks,
>> Oliver
>>
>> Am 12.06.2015 um 07:00 schrieb Oliver Sander:
>>> Dear pdelab team,
>>> please find attached three cleanup patches for pkqkfem.hh and poisson.hh.
>>> Thanks for considering,
>>> Oliver
>>>
>>
>>
> 
> 
> 
>> _______________________________________________
>> dune-pdelab mailing list
>> dune-pdelab at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-pdelab
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.dune-project.org/pipermail/dune-pdelab/attachments/20150616/b391cf0f/attachment.sig>