[dune-pdelab] dune-pdelab | [WIP] Fix nonoverlapping mode for Dune 2.4 (#69)

Christian Engwer gitlab at conan2.iwr.uni-heidelberg.de
Sun Sep 27 23:50:33 CEST 2015


New comment for Merge Request 69

http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/merge_requests/69#note_2167


Christian Engwer

Let me comment on your raised questions:
 - EntitySet:
   - as this is the outcome of our telephone discussion, I'm obviously in favour of this change, but have some smaller comments
   - did you model the EntitySet similar to dune-functions? We might want follow the interface already now, to have an easy transistion, once 2.4 is out.
   - I don't like the name AllEntitySet, as it suggests to include also vertices etc. Again, if we keep the naming scheme and API from functions, we can remove our implementation without changing the other code, once functions in a dependency.
 - the 2.4 behaviour is fine with me.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.dune-project.org/pipermail/dune-pdelab/attachments/20150927/8b9bfc7a/attachment.htm>


More information about the dune-pdelab mailing list