[Dune] suggestion for testing

[Christian Engwer]

Hi Andreas,

> if you had read our mail carefully and without
> being biased you would have noticed that we were
> not complaining in any way at all!

Sorry if I misinterpreted your mail.

> I do not remember the mail you are referring to, I
> must have missed it. We would have otherwise gladly
> added to patch to our tests.

So I think we agree on this. For bigger changes it is always better if
we test these in advance. I will try to keep my current custom and
upload involved patches to flyspray. But I also ask everybody again to
test these changes. In case Martin finds time to come to Stuttgart we
could then also discuss different ways to incorporate/unify the test
systems in Stuttgart and Freiburg, in order to get the maximum use.

Cheers
  Christian

> I am getting rather fed up with this discussion.
> We have made a suggestion, it seems not to be 
> welcomed, so let us forget it.
> 
> Andreas
> 
> On Mon, 19 May 2008 11:19:07 +0200
>  Christian Engwer <christi at uni-hd.de> wrote:
> > Hi,
> > 
> > there was patch concerning this topic. I appended a patch
> > with the
> > last changes about 2 weeks ago. I didn't commit the patch
> > on
> > purpose. I asked all developers to test this, in order to
> > avoid
> > unexpected problems. So it would have been easy to apply
> > this patch to
> > your testsuite. As no complaines occured, I commited the
> > patch. At
> > least in this case you can not complain afterwards.
> > 
> > Christian
> > 
> > On Mon, May 19, 2008 at 09:14:24AM +0200, Andreas Dedner
> > wrote:
> > > Hi,
> > > some of the recent changes to the build system
> > > are quite fundamental and therefore
> > > a) difficult to test
> > > b) rather devastating for users not accustomed to
> > >    the ''guts'' of the build system.
> > > We were therefore discussing possibilities of
> > > increasing the success rate of checkins through
> > > testing patches on different installations of libtool,
> > > g++ Version etc.
> > > We have a quite complex nightly build for dune-fem
> > > using tar balls from the svn head and testing with 
> > > all kinds of
> > > grids and similar things. It would not be very
> > > difficult to add new changes to the repository, e..g,
> > > the build system after checkout. This would only
> > > require a patch. This can be easily done by
> > > sending us a file "patchfile" generated using
> > >   svn diff > patchfile
> > > as an email.
> > > So our suggestion would be: before a major change to
> > the
> > > build system is committed, the patch could be send to
> > us
> > > and we add it to our nightly build. The next day
> > > we know if everything worked out and can either commit
> > > the patch ourself our give an ok for the patch to be
> > > commit. If something went wrong we can try to figure
> > > out what the problem was and make a suggestion for
> > > correcting the problem, which should at least then
> > > work on our system and others can then try it out on
> > > there installation.
> > > Martin would be willing to perform this task on our
> > side!
> > > And before I forget:
> > > 1) we would all like to thank Christian for the huge
> > > amount of work he is investing into the build systen;
> > > we appreciate how difficult it is and also how
> > > difficult these change are to test throughly.
> > > 2) if somebody else would also like to test a patch
> > > he should just yell. All one has to do is
> > > run the command
> > >   patch -p0 < patchfile
> > > 
> > > Best regards
> > > the Freiburg team.
> > > 
> > > PS: tonight we got the following message:
> > > cd . && ./bin/dunecontrol --only=dune-common m4create
> > > writing dependencies.m4
> > >     for dune-common 1.2svn dune at dune-project.org
> > > { test ! -d dune-common-1.2svn || { find
> > dune-common-1.2svn
> > > -type d ! -perm -200 -exec chmod u+w {} ';' && rm -fr
> > > dune-common-1.2svn; }; }
> > > test -d dune-common-1.2svn || mkdir dune-common-1.2svn
> > > cp: cannot stat `./dune-common.m4': No such file or
> > > directory
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > Dune mailing list
> > > Dune at dune-project.org
> > > http://lists.dune-project.org/mailman/listinfo/dune
> > > 
> 
> 
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
>