[Dune] unusual first line in alu3dgridfactory.hh

Christian Engwer christi at uni-hd.de
Wed Oct 8 15:00:54 CEST 2008


On Wed, Oct 08, 2008 at 02:49:17PM +0200, Oliver Sander wrote:
> Dear Dune!
> I just stumbled upon the following line in alu3dgridfactory.hh
> (it is the first one).
> 
> #if defined ENABLE_ALUGRID && !defined DUNE_ALU3DGRID_FACTORY_HH
> 
> I understand what it is supposed to do.  However, I don't really like it 
> because
> it is non-standard and leads to surprising consequences.  In particular, my
> doxygen documentation didn't include the ALUGridFactory. 
> 
> Could we please remove the 'define ENABLE_ALUGRID' and similar
> occurrences elsewhere?

Actually ENABLE_ALUGRID is not only an anoyance when building doxygen,
but is just plain wrong. When checking for a feature, e.g. alugrid,
one must use the HAVE_ defines.

Christian




More information about the Dune mailing list