[Dune] unusual first line in alu3dgridfactory.hh

[Oliver Sander]

Christian Engwer schrieb:
> On Wed, Oct 08, 2008 at 02:49:17PM +0200, Oliver Sander wrote:
>   
>> Dear Dune!
>> I just stumbled upon the following line in alu3dgridfactory.hh
>> (it is the first one).
>>
>> #if defined ENABLE_ALUGRID && !defined DUNE_ALU3DGRID_FACTORY_HH
>>
>> I understand what it is supposed to do.  However, I don't really like it 
>> because
>> it is non-standard and leads to surprising consequences.  In particular, my
>> doxygen documentation didn't include the ALUGridFactory. 
>>
>> Could we please remove the 'define ENABLE_ALUGRID' and similar
>> occurrences elsewhere?
>>     
>
> Actually ENABLE_ALUGRID is not only an anoyance when building doxygen,
> but is just plain wrong. When checking for a feature, e.g. alugrid,
> one must use the HAVE_ defines.
>
> Christian
>   
To make my complaint more precise:  I don't actually care much
about what you test, but it should not be in the first line of a
header, combined with the single-inclusion test.

Oliver

-- 
************************************************************************
* Oliver Sander                ** email: sander at mi.fu-berlin.de        *
* Freie Universität Berlin     ** phone: + 49 (30) 838 75217           *
* Institut für Mathematik      ** URL  : page.mi.fu-berlin.de/~sander  *
* Arnimallee 6                 ** -------------------------------------*
* 14195 Berlin, Germany        ** Member of MATHEON (www.matheon.de)   *
************************************************************************