[Dune] [#445] Add a module for approximate comparison [patch] (Attachment added)

[Martin Nolte]

Hi all,

it seems to me that the problem really is that there are some STL compatible 
classes within the namespace Dune. If this is the case, we should ask 
ourselves: Should these classes be in this namespace? Or should they be in the 
namespace std?

Before we change the coding style in one module just to conform to the STL, I 
would suggest to move the problematic classes into the namespace std. Then, 
within this namespace we enforce STL coding style and within the namespace 
Dune we enforce Dune coding style. I think these are the clearest rules and 
little change is needed to conform to them.

Cheers,

Martin

Christian Engwer wrote:
> Hi Andreas,
> 
>> I do not see any reason to change our coding style
>> (documented on the dune homepage) and as far as I
>> see it the code here seems to be written in the style
>> use in the other dune modules. So what exactly is the
>> suggestion for changing the style?
> 
> On the last meeting (and also before) we were discussing the codign
> style. We do have a coding style. But we were never ably to completely
> comply to the coding style. The problem erises for example, where ever
> you write a class that should be stl compatible. This lead to the
> situation where we have a wild mixture of camelcase and stl-style code
> in dune-common. I would not suggest to change the stye of all
> modules, bu the question is, how to procede in future. I think we must
> consider changing the dune-common style guidelines to stl-style,
> because especially in dune-common a lot of classes are intended to be
> stl compatible. This must not be a "we change everything right away"
> decision, but would affect new classes.
> 
> I vote for a change in the coding style.
> 
> Christian
> 
> PS: Even in dune-grid the style is not completely consistent. And many
> 	aspects of coding style were never even discussed.
> 
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune

-- 
Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5642
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany