[Dune] [#677] gridtype.hh documentation is wrong

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Jö Fahlke (joe) 

Attached to Project - Dune
Summary - gridtype.hh documentation is wrong
Task Type - Bug Report
Category - Grid
Status - New
Assigned To - 
Operating System - Unspecified / All
Severity - Low
Priority - Normal
Reported Version - SVN
Due in Version - Undecided
Due Date - Undecided
Details - dune/grid/utility/griddtype.hh says that the way to choose the grid type at
make time is
======================================================================
make GRIDDIM=3 GRIDTYPE=ALBERTAGRID myprogram
======================================================================
(OK, I tested with GRIDDIM=2 GRIDTYPE=ALUGRID_SIMPLEX, but the same principle
applies...)  However, this does not seem to work, at least not when compiling
dune/grid/io/file/dgfparser/test/tester.  What _does_ work however is
======================================================================
make CPPFLAGS="-DGRIDDIM=2 -DALUGRID_SIMPLEX" myprogram
======================================================================
(note that GRIDTYPE is not defined in this case).  There seem to be two issues
here:

 (1) The variables must be passed as preprocessor defines and not as make
     variables.  This could be an error in some Makefile.am
 (2) GRIDTYPE is not used and does not appear in the actual code in
     gridtype.hh.  Instead, the code checks whether ALBERTAGRID, ALUGRID_CUBE,
     ALUGRID_SIMPLEX, etc. are defined and defined the GridType typedef
     accordingly.


More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=677

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.