[Dune] Transition from SmartPointer to shared_ptr

Oliver Sander sander at mi.fu-berlin.de
Wed Oct 14 18:43:05 CEST 2009


Hi Markus!
>
>
> This is indeed very problematic. Did I miss it or was this never
> mentioned before hand? I vaguely recall that you said shared_ptr is a
> direct copy of SmartPointer...
>   
This was never mentioned, because I myself only learned about
it when trying to run the smartpointer test with the tr1 implementation
of shared_ptr.  This emphasizes the reason why I think following
the standard library exactly is a good thing:  when something is
almost like a standard people (me, foremost) tend to think that
it behaves completely like the standard.  I did compare method
names but this semantic change escaped me.

> No this puts the whole discussion about the transistion into  a
> another light. I would have objected if I had known this beforehand.
>
> Anyway I was not very convinced why this change was useful. But as it
> was considered minor and nobody told anything  about the semantics
> change, I just kept my doubts to myself.
>   
see above
> I cannot anymore. Maybe we should have a general discussion about
> moving to tr1 and why it is useful and worth the additional
> work. (At least with tuples we started this change and it was never 
> finished, because there is a long tail of containers that behave like
> a tuple, and therefore should be usable with the tuple TMPs).
>   

> IMHO all these changes lead to problems with the backwards
> compatibility of our code. Or does everybody check his code without
> tr1 enabled? (I know that I usually don't!) Can we really be sure that
> Dune still works with gcc-3.4? Maybe, but if someone addresses the
> fixed size Dune::array with the tuple TMPs it will be broken.
>   
This is why there is an automatic test system.  It checks with
gcc-3.4 every day.

> Back to the change of smartpointer:
>
> Of course I rely on the behaviour of the old implementation!
> Hopefully nobody changed ArrayList which used the old smartpointer and
> relied on it. Otherwise parallel ISTL is broken :/
>   
I did, upon being urged to do so.  I will revert that patch in a second.

Yours,
Oliver

> Regards,
>
> Markus
>
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune
>   


-- 
************************************************************************
* Oliver Sander                ** email: sander at mi.fu-berlin.de        *
* Freie Universität Berlin     ** phone: + 49 (30) 838 75348           *
* Institut für Mathematik      ** URL  : page.mi.fu-berlin.de/~sander  *
* Arnimallee 6                 ** -------------------------------------*
* 14195 Berlin, Germany        ** Member of MATHEON (www.matheon.de)   *
************************************************************************





More information about the Dune mailing list