[Dune] [#779] test-ug fails, apparently to to allocator problems in the GenericGeometries

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#779 - test-ug fails, apparently to to allocator problems in the GenericGeometries
User who did this - Oliver Sander (sander)

----------
Hi Martin!
Thank you very much for your help.  I think I understand the problem now.

Unfortunately, I am forced to revert your patch.  Here are my reasons:
- The patch is illegible.  It is almost 900 lines long, and most of the changes appear to be moving code around and some cleanup.
  While the resulting code may be easier to read (which I am not sure of; there are new classes which come entirely without documentation),
  it is impossible for me to see where the actual fix is.  If you feel that UGGrid needs cleanup feel free to submit patches, but please
  separate them from bugfixes.
- I don't think that the problem should be fixed in UGGrid.  UGrid creates new GenericGeometry objects most of the time only because
  there is no way to set the coordinates of a given object directly.  Assigning from a newly created object is just a hack, because no
  such method exists.  Adding such a method would solve the problem, because memory doesn't get invalidated anymore when setting up
  an existing GenericGeometry object.  It would also make code using the GenericGeometries more legible, and may yield a speed improvement, because
  unneeded calls to the memory management would be avoided.

best,
Oliver
 
 
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=779#comment1989

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.